Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync reverse-string #749

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

fejan-malek
Copy link
Contributor

@fejan-malek fejan-malek commented Jun 13, 2024

#740

also added missing test cases

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@fejan-malek
Copy link
Contributor Author

@mk-mxp

Need help

I have added 3 new test cases with the below string and it failed.

子猫
Würstchenstand
ผู้เขียนโปรแกรม

I even tried to update the example code with grapheme_extract and mb_substr but still no success tests.

@mk-mxp mk-mxp changed the title Change: remove strict types comment and updated test and test.toml file Sync reverse-string Jun 13, 2024
@mk-mxp
Copy link
Contributor

mk-mxp commented Jun 13, 2024

@fejan92 I'm too busy today. Thanks for your patience!

#740

@fejan-malek
Copy link
Contributor Author

Yeah, no problem.

There is no rush at all.

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In canonical-data.json the failing tests are marked with "scenarios": ["unicode"],. In general, adding a scenario to an existing exercise will break too many things. So we only add them when other changes also make students code fail.

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jun 14, 2024
@fejan-malek fejan-malek requested a review from mk-mxp June 18, 2024 05:03
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! Again something learned about the inner workings of Exercism - I hope removing the new tests wasn't too frustating.

@mk-mxp mk-mxp merged commit 9387123 into exercism:main Jun 18, 2024
12 checks passed
@fejan-malek fejan-malek deleted the change-reverse-string branch June 19, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants