Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync raindrops #750

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Sync raindrops #750

merged 3 commits into from
Jun 14, 2024

Conversation

fejan-malek
Copy link
Contributor

#741

Added missing test cases and updated config.json

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp mk-mxp changed the title Change raindrops Sync raindrops Jun 13, 2024
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the "description" of the canonical-data.json for the @testdox. You also find these in tests.toml.

exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
exercises/practice/raindrops/RaindropsTest.php Outdated Show resolved Hide resolved
@fejan-malek fejan-malek requested a review from mk-mxp June 14, 2024 07:50
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great work!

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jun 14, 2024
@mk-mxp mk-mxp merged commit 4f5b55d into exercism:main Jun 14, 2024
12 checks passed
@fejan-malek fejan-malek deleted the change-raindrops branch June 18, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants