-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Exercise]: DnD Character #232
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, although you have to fix that config.json ci.
I fixed the merge conflict for you, but if you like next time to solve it yourself so are you free to.
2c35c69
to
25bc08b
Compare
This should be ok now, that one typo really mess thing up around. Also thank you for fixing the merge conflict, next time if it happen in the config.json file just let me try to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
This should be ok now, that one typo really mess thing up around. Also thank you for fixing the merge conflict, next time if it happen in the config.json file just let me try to fix it. |
I mean it mostly happens if 2 prs have changed the config.json at the same place, and I did a pr before you that did that. Other than that what I mostly try to do is to change config.json on different places all the time as long as I keep the difficulty rule true. |
Add DnD character exercise