Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Exercise]: DnD Character #232

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Conversation

glaxxie
Copy link
Contributor

@glaxxie glaxxie commented Jul 25, 2023

Add DnD character exercise

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 25, 2023
@meatball133 meatball133 reopened this Jul 26, 2023
Copy link
Member

@meatball133 meatball133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, although you have to fix that config.json ci.
I fixed the merge conflict for you, but if you like next time to solve it yourself so are you free to.

@glaxxie
Copy link
Contributor Author

glaxxie commented Jul 26, 2023

This should be ok now, that one typo really mess thing up around. Also thank you for fixing the merge conflict, next time if it happen in the config.json file just let me try to fix it.
I suppose I can just merge with whatever the current PR is so i can place the slug inside the config.json file at the right place to avoid merge conflict altogether?

Copy link
Member

@meatball133 meatball133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@meatball133 meatball133 merged commit 6c4cf22 into exercism:main Jul 26, 2023
3 checks passed
@glaxxie
Copy link
Contributor Author

glaxxie commented Jul 26, 2023

This should be ok now, that one typo really mess thing up around. Also thank you for fixing the merge conflict, next time if it happen in the config.json file just let me try to fix it.
I suppose I can just merge with whatever the current PR is so i can place the slug inside the config.json file at the right place to avoid merge conflict altogether?

@meatball133
Copy link
Member

I mean it mostly happens if 2 prs have changed the config.json at the same place, and I did a pr before you that did that. Other than that what I mostly try to do is to change config.json on different places all the time as long as I keep the difficulty rule true.

@glaxxie glaxxie deleted the pwrshell_dnd_char branch December 7, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants