Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Exercise]: Triangle #233

Merged
merged 5 commits into from
Jul 26, 2023
Merged

[New Exercise]: Triangle #233

merged 5 commits into from
Jul 26, 2023

Conversation

glaxxie
Copy link
Contributor

@glaxxie glaxxie commented Jul 25, 2023

No description provided.

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 25, 2023
@meatball133 meatball133 reopened this Jul 26, 2023
meatball133
meatball133 reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@meatball133 meatball133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 3 tiny nits

exercises/practice/triangle/.docs/instructions.append.md Outdated Show resolved Hide resolved
exercises/practice/triangle/.docs/instructions.append.md Outdated Show resolved Hide resolved
exercises/practice/triangle/.docs/instructions.append.md Outdated Show resolved Hide resolved
meatball133
meatball133 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@meatball133 meatball133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job! ✨

@meatball133 meatball133 merged commit 1471054 into exercism:main Jul 26, 2023
3 checks passed
@glaxxie
Copy link
Contributor Author

glaxxie commented Jul 26, 2023

Thank you for all the help!
I will take a look at more exercises and see which one that i can do and let you know on the forum so you don't waste your time with duplication.

@meatball133
Copy link
Member

No problems, also on the bottom of this page can you see all unimplemented exercises as well as the link to the problem spec repo: https://exercism.org/tracks/powershell/build

@glaxxie glaxxie deleted the pwrshll_triangle branch December 7, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meatball133 meatball133 meatball133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glaxxie @meatball133