Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alphametics: Update json for new "input" policy #1035

Merged
merged 2 commits into from
Jan 5, 2018
Merged

alphametics: Update json for new "input" policy #1035

merged 2 commits into from
Jan 5, 2018

Conversation

Stargator
Copy link
Contributor

#996 Updated the schema for canonical data. So I am updating the exercise's json to reflect the change.

@Stargator Stargator self-assigned this Dec 14, 2017
rpottsoh
rpottsoh previously approved these changes Dec 15, 2017
View reviewed changes
@rpottsoh
Copy link
Member

Should be OK to merge unless you are waiting on #1024 . #1024 needs to bump the version, which will affect your version....

@Stargator
Copy link
Contributor Author

@rpottsoh I'm fine with waiting until #1024 is done and I'll go ahead and bump my version as anticipated.

@Stargator Stargator force-pushed the input-alphametics branch 2 times, most recently from b508b50 to 9abf559 Compare December 19, 2017 16:37
@Stargator
Copy link
Contributor Author

Updated to reflect recent changes

@rpottsoh rpottsoh dismissed their stale review December 19, 2017 17:14

Last test case needs "input" object.

rpottsoh
rpottsoh previously requested changes Dec 19, 2017
View reviewed changes
Copy link
Member

@rpottsoh rpottsoh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last test case needs input object.

ErikSchierboom
ErikSchierboom requested changes Jan 4, 2018
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also convert the last test case (with the many addends) to the new structure? You might want to rebase onto the latest master first.

@rpottsoh rpottsoh dismissed their stale review January 4, 2018 17:02

Thanks for making the changes I requested, but @ErikSchierboom's requested changes trump my approval, so I am dismissing my review.

@rpottsoh rpottsoh force-pushed the input-alphametics branch 2 times, most recently from 4a795aa to dcc6a4e Compare January 5, 2018 01:45
@rpottsoh
Copy link
Member

rpottsoh commented Jan 5, 2018 •
edited
Loading

@ErikSchierboom I have managed to rebase....

@rpottsoh rpottsoh self-assigned this Jan 5, 2018
@ErikSchierboom ErikSchierboom merged commit 50dc06b into exercism:master Jan 5, 2018
@ErikSchierboom
Copy link
Member

@rpottsoh @Stargator Thanks for this!

@petertseng petertseng mentioned this pull request Jan 11, 2018
Merged
petertseng added a commit to exercism/haskell that referenced this pull request Jan 11, 2018
@petertseng
alphametics 1.2.0.4: Add test with 199 addends (#638)
b276a98 
1.1.0: new test
exercism/problem-specifications#1024
1.1.1: description
exercism/problem-specifications#1045
1.2.0: input object
exercism/problem-specifications#1035
@Stargator Stargator deleted the input-alphametics branch September 9, 2018 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

@rpottsoh rpottsoh rpottsoh approved these changes

Assignees

@rpottsoh rpottsoh

@Stargator Stargator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stargator @rpottsoh @ErikSchierboom