[custom-set] Add test for deduplication #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivated by: exercism/rust#1275
This was referenced Sep 16, 2023
|
Is a set with duplicate elements a valid set? I think part of what may be adding to confusion here is that an array notation is being used to hold the contents of a set. Also, I am not sure this is a test that tests for deduplication as exercism/rust#1741 seemed concerned about and this was identified as the solve covering it. |
|
sorry for opening this PR without a forum post, discussion should continue here |
ErikSchierboom
approved these changes
Sep 18, 2023
| }, | ||
| { | ||
| "uuid": "0b95204d-93fa-4b60-9499-1e34f228c336", | ||
| "description": "set is a subset of set with duplicates", |
There was a problem hiding this comment.
A set with with duplicates isn't technically a set 🤷
There was a problem hiding this comment.
Yes 😅 but it's shorter than "a set constructed from an array with duplicates" 😂
There was a problem hiding this comment.
It is, but I actually like the second version better!
ErikSchierboom
approved these changes
Sep 20, 2023
iHiD
approved these changes
Sep 24, 2023
IsaacG
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have a test case where a set is instantiated with a slice containing duplicate values.
motivated by:
exercism/rust#1275