Approaches for leap
#330
Merged
Approaches for leap
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BNAndras
added
x:action/create
BNAndras
force-pushed
the
add-leap-approaches
branch
from
42256b9
to
aad677d
Compare
|
Awesome job! |
dreig
reviewed
Jan 15, 2024
ErikSchierboom
approved these changes
Jan 15, 2024
Comment on lines
16
to
24
| [The match form][match-form] compares an expression to a series of patterns describing its shape. | ||
| For this exercise, this takes the form of creating a list containing three Boolean values representing whether a year is divisible by 4, 100, or 400. | ||
| The first three patterns describe a three-element list, but each one encodes a literal `#t` to be matched in a different location. The other elements can be any value due to `_`. | ||
| The first pattern accepts any value for the first two slots but requires `#t` in the third. | ||
| This means any year divisible by 400 will match this pattern regardless of whether it's also divisible by 4 or 100. | ||
| The second pattern accepts any value for the first and last slot but requires `#t` in the second slot. | ||
| This means any year that's divisible by 100 but not by 400 matches this pattern. | ||
| If it were divisible by 400, the first pattern would have matched. | ||
| The third pattern operates similarly, and finally any remaining value that didn't match the previous patterns will satisfy the last pattern. |
There was a problem hiding this comment.
My only suggestion would be to maybe copy-paste (part of) the pattern matching code in the description, to prevent students from having to scroll up for the code reference.
There was a problem hiding this comment.
I'll take care of that tonight. Thanks for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.