Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[queen-attack] Implementation #615

Merged
merged 7 commits into from May 15, 2023
Merged

[queen-attack] Implementation #615

merged 7 commits into from May 15, 2023

Conversation

habere-et-dispertire
Copy link
Contributor

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this May 11, 2023
@iHiD iHiD reopened this May 11, 2023
@habere-et-dispertire habere-et-dispertire marked this pull request as ready for review May 11, 2023 20:32
@habere-et-dispertire
Renamed:
df7111f 
* QueenAttack => Queen
* is-atack => can-attack

Changed comparison operator:

* <==> => <eqv>

Dropped .raku for Boolean:

* %case<expected>.raku =>  %case<expected>
@habere-et-dispertire
Copy link
Contributor Author

habere-et-dispertire commented May 12, 2023 •
edited

This passes locally for me of macOS:

$ prove -re raku exercises/practice/queen-attack/.meta/solutions/queen-attack.rakutest 
exercises/practice/queen-attack/.meta/solutions/queen-attack.rakutest .. ok    
All tests successful.
Files=1, Tests=12,  6 wallclock secs ( 0.05 usr  0.01 sys +  2.14 cusr  0.27 csys =  2.47 CPU)
Result: PASS

@habere-et-dispertire
Copy link
Contributor Author

@m-dango : Thank you for all your help ! I really appreciate it. o/

😀

@m-dango m-dango merged commit d58d736 into exercism:main May 15, 2023
5 checks passed
@habere-et-dispertire habere-et-dispertire deleted the queen-attack branch May 15, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-dango m-dango m-dango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@habere-et-dispertire @m-dango @iHiD