Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prime-factors] Implementation #618

Merged
merged 7 commits into from Jun 18, 2023
Merged

[prime-factors] Implementation #618

merged 7 commits into from Jun 18, 2023

Conversation

habere-et-dispertire
Copy link
Contributor

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this May 13, 2023
@m-dango m-dango reopened this May 15, 2023
@habere-et-dispertire
Copy link
Contributor Author

What does :

configlet / configlet Expected — Waiting for status to be reported

mean ?

@habere-et-dispertire habere-et-dispertire marked this pull request as ready for review May 21, 2023 16:00
m-dango
m-dango requested changes May 31, 2023
View reviewed changes
exercises/practice/prime-factors/prime-factors.rakutest Outdated

cmp-ok( # begin: 924fc966-a8f5-4288-82f2-6b9224819ccd
factors(1),
"eq",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~ or eqv for list comparison.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm looking for a type-agnostic comparator (cmp), so that we can be accepting of solutions returning different forms of the same thing but I'm unsure how to go about that or if it is advised ?

@m-dango m-dango merged commit 1eb708c into exercism:main Jun 18, 2023
5 checks passed
@habere-et-dispertire habere-et-dispertire deleted the prime-factors branch June 25, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-dango m-dango m-dango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@habere-et-dispertire @m-dango