Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[killer-sudoku-helper] Implementation #626

Merged
merged 6 commits into from Jun 24, 2023

Conversation

habere-et-dispertire
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jun 3, 2023
@ErikSchierboom ErikSchierboom reopened this Jun 8, 2023
@habere-et-dispertire habere-et-dispertire marked this pull request as ready for review June 8, 2023 08:29
@m-dango m-dango merged commit 0a3a68c into exercism:main Jun 24, 2023
5 checks passed
@habere-et-dispertire habere-et-dispertire deleted the killer-sudoku-helper branch June 24, 2023 20:59
@habere-et-dispertire
Copy link
Contributor Author

template-data.yaml reads :

killer-sudoku-helper( :sum(%s), :size(%s), :exclude%s ),

Should that really not be :

killer-sudoku-helper( :sum(%s), :size(%s), :exclude(%s) ),

?

@m-dango
Copy link
Member

m-dango commented Jun 25, 2023

template-data.yaml reads :

killer-sudoku-helper( :sum(%s), :size(%s), :exclude%s ),

Should that really not be :

killer-sudoku-helper( :sum(%s), :size(%s), :exclude(%s) ),

?

@habere-et-dispertire No, see the generated test. That placeholder already contains parentheses, and previously the generated test would nest an unnecessary additional pair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants