Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resistor-color-duo] Implementation #639

Merged
merged 5 commits into from Aug 29, 2023

Conversation

habere-et-dispertire
Copy link
Contributor

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 28, 2023
@habere-et-dispertire habere-et-dispertire marked this pull request as ready for review July 28, 2023 09:30
@m-dango
Copy link
Member

m-dango commented Aug 2, 2023

I'm a little confused by the last test case of this exercise. The documentation states it expects a 2 digit number, but the last case is 1 digit.

Wondering if its worth switching to eqv to compare this one, since returning "01" would pass and I think that defeats the point?

@habere-et-dispertire
Copy link
Contributor Author

On the JavaScript track it is not tested. On the Bash track a single digit 1 is expected. Happy to confusticate and make it match, but I'd hope that the documentation would spell it out for this a beginner exercise.

@habere-et-dispertire
Copy link
Contributor Author

Thanks for finding out the intent, @m-dango. 👍

@m-dango m-dango merged commit 55f7cf9 into exercism:main Aug 29, 2023
5 checks passed
@habere-et-dispertire habere-et-dispertire deleted the resistor-color-duo branch September 3, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants