generator: support example solutions in .meta/solutions #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insti
reviewed
May 3, 2017
| @@ -13,7 +13,7 @@ def initialize | |||
| @paths = FixturePaths | |||
| @exercise_name = 'alpha' | |||
| end | |||
| attr_reader :paths, :exercise_name | |||
| attr_accessor :paths, :exercise_name | |||
There was a problem hiding this comment.
I'd rather exercise name modification being done via constructor argument rather than attr_accessor
but I can understand:
I'd rather live with the mess than refactor to get an elegant solution that would be around for a day or two.
This was referenced May 3, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of moving generator bits under
.meta, we're movingexample.rbunder.meta/solutions. This PR is the first step: adding support for example solutions as.meta/solutions/<exercise_name>.rbwhile retaining support for the current location.Tests are included for both old and new locations.
Supporting both old and new introduces a bit of mess that will get cleaned up when support for the old location is removed. I'd rather live with the mess than refactor to get an elegant solution that would be around for a day or two...