Reduce image size #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senekor
force-pushed
the
reduce-image-size
branch
from
8bf8ba3
to
ff9cf0b
Compare
`+nightly` is actually not compatible with a pinned version of nightly. But since our way of installing rust set the pinned nightly toolchain as default anyway, we don't need it anymore.
|
How much do we save with this? |
|
A bit more than 50% or 1GB, old size was 2GB plus change, new size is ~950MB. |
|
95O is with alpine, I switched to debian though to see if CI is fixed |
|
debian is 1.6GB but it passes CI, while alpine does not. debian-slim is 970MB, which is almost the same as alpine, let's see if it passes CI. |
ErikSchierboom
approved these changes
Jul 20, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #75