Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise Pangram should define which alphabet is expected #150

Closed
cjschneider2 opened this issue Jun 30, 2016 · 3 comments
Closed

Exercise Pangram should define which alphabet is expected #150

cjschneider2 opened this issue Jun 30, 2016 · 3 comments

Comments

@cjschneider2
Copy link

While doing this exercise I've noticed that the README.md does not mention which alphabet one should be checking against. I originally assumed an English alphabet, yet the last test in German being considered a pangram made me reconsider. I guess in summary the alphabet / language to be tested against should be defined exercise problem description, otherwise this is a rather unbounded problem.

@cjschneider2
Copy link
Author

I can put up a pull request that fixes it, I just wanted other people's opinion on the matter.

@IanWhitney
Copy link
Contributor

Clarification of the readme would certainly be useful. In the case of this exercise it's only looking for ascii characters. Nothing in extended ascii (or unicode, etc.) should count.

The edge case that the German test is trying to cover is that non-ascii characters don't blow up your code. It does contain a full ascii pangram once you filter out all of the extended characters.

@kotp
Copy link
Member

kotp commented Jun 30, 2016

exercism/problem-specifications#284 hopefully clarifies this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants