Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tests that disallowed correct answers #1896

Closed
wants to merge 1 commit into from
Closed

Fixed tests that disallowed correct answers #1896

wants to merge 1 commit into from

Commits on Apr 6, 2024

  1. Fixed tests that disallowed correct answers 

    The tests assume that there can be only one way to solve the problem: if the number is even, divide it by 2 and if the number is odd, multiply it by 3 and add 1.

Multiplying by 3 and adding 1 can cause an overflow, which the tests accommodate by allowing `None` as a correct response whenever `u64` overflows occur.

The problem is that `None` is considered to be ***the only*** correct response in that case, when every nonzero `u64` has a correct answer that can be put into `Some`. For example, overflow can be avoided by converting the input `u64` into a `u128` and then getting the result using `u128` arithmetic.

This commit corrects the tests so that either `None` or the correct answer is allowed when `u64` overflow can occur.
    @ChaiTRex
    ChaiTRex committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    d186afc View commit details
    Browse the repository at this point in the history