Add Transpose exercise #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
|
Nice! |
regnerjr
reviewed
Dec 5, 2016
| } | ||
| } | ||
|
|
||
| return result.map { stripTrailingWhitespace($0) } |
There was a problem hiding this comment.
Great use of map! I just wanted to point out that map can also take a function as a parameter. Instead of the trailing closure which is explicitly calling the function you could instead write.
return result.map(stripTrailingWhitespace)
Which is a little cleaner.
There was a problem hiding this comment.
good call. That would be an awesome rule to add to Swiftlint. You should suggest it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast with the Ruby version, the Swift version operates on arrays of
Strings, since the syntax for multi-line strings is rather cumbersome.