Support timeout for tool #47

ErikSchierboom · 2021-09-16T07:34:09Z

Closes #45

tools.json

lib/tooling_invoker/configuration.rb

iHiD · 2021-09-16T19:52:32Z

So we also need to use this value.

Best place is probably lib/tooling_invoker/exec_docker.rb (that's also where the network config is used).

You can probably remove the job.timeout_s method and just use this call instead?

Support timeout for tool

4dd7c10

ErikSchierboom commented Sep 16, 2021

View reviewed changes

tools.json Outdated Show resolved Hide resolved

ErikSchierboom requested a review from iHiD September 16, 2021 07:39

iHiD reviewed Sep 16, 2021

View reviewed changes

lib/tooling_invoker/configuration.rb Outdated Show resolved Hide resolved

ErikSchierboom added 3 commits September 17, 2021 14:40

Set Ruby test runner timeout to 4

bbef397

DRY-up the config code

252990e

Use timeout from tool

8b11620

ErikSchierboom requested a review from iHiD September 17, 2021 13:22

ErikSchierboom force-pushed the timeout-for-tool branch 2 times, most recently from df117ca to 9477048 Compare September 17, 2021 13:25

Fix Rubocop version

62d73ea

ErikSchierboom force-pushed the timeout-for-tool branch from 9477048 to 62d73ea Compare September 17, 2021 13:27

ErikSchierboom and others added 2 commits September 17, 2021 15:29

Fix test

6d083a7

Merge branch 'main' into timeout-for-tool

4821e12

iHiD merged commit 73f1979 into main Sep 28, 2021

iHiD deleted the timeout-for-tool branch September 28, 2021 14:12

Provide feedback