Rename iteration to submission #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
changed the title
iHiD
force-pushed
the
rename-iteration-to-submission
branch
from
13c2091
to
1ba9143
Compare
iHiD
changed the title
iHiD
commented
Oct 6, 2020
| @@ -21,7 +21,7 @@ gem 'rest-client' # http | |||
| gem 'mandate', '0.4.0.beta.1' | |||
|
|
|||
| # Setup dependencies | |||
| gem 'exercism-config', '>= 0.43.0' | |||
| gem 'exercism-config', '>= 0.44.0' | |||
There was a problem hiding this comment.
This changes the config so the field is now aws_submissions_bucket not aws_iterations_bucket
iHiD
commented
Oct 6, 2020
| @@ -5,8 +5,9 @@ ruby '2.6.6' | |||
| # Service/framework dependencies | |||
| gem 'rails', | |||
| git: 'http://github.com/rails/rails.git', | |||
| ref: '7101489293ece071013417aeed2da3aa1b0927c9' | |||
| ref: '207f116234374d6414593246240b05261a96fa3a' | |||
There was a problem hiding this comment.
Sporadic bumping of Rails that I thought I'd do while breaking everything else at the same time 😉
iHiD
commented
Oct 6, 2020
| @@ -1,3 +1,5 @@ | |||
| class Delayed::Job | |||
| self.abstract_class = true | |||
There was a problem hiding this comment.
Needed because of rails/rails#40219
iHiD
force-pushed
the
rename-iteration-to-submission
branch
from
1ba9143
to
c82ee24
Compare
|
I'm going to merge this, because everything else should be rebased onto it, and doing so should be straightforward. But if it gets more out of sync it'll become impossible 🙂 |
iHiD
force-pushed
the
rename-iteration-to-submission
branch
from
c82ee24
to
62d1e9a
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not need reviewing (else you'll be here all day)
This PR renames
iterationstosubmissions.Comments etc will still be stored on iterations, not on submissions.