Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotational-cipher exercise #73

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Add rotational-cipher exercise #73

merged 2 commits into from
Oct 25, 2023

Conversation

kahgoh
Copy link
Contributor

@kahgoh kahgoh commented Oct 20, 2023

rotational-cipher for Nibbly November

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 20, 2023
@kahgoh kahgoh changed the title Add rotation-cipher exercise Add rotational-cipher exercise Oct 20, 2023
@keiravillekode
Copy link
Contributor

Four trivial suggestions:

  1. All but the first of the test cases can use xtest() instead of test(). This suggestion would also apply to nucleotide-count/nucleotide-count.spec.js
  2. No need to import exp in rotational-cipher.spec.js as it is not used.
  3. In proof.spec.wat, consider defining (global $A i32 (i32.const 65)) etc. like in rna-transcription/.meta/proof.ci.wat
  4. Consider adding .docs/instructions.append.md
## Reserved Memory

Bytes 64-319 of the linear memory are reserved for the input string.

The input string can be modified in place if desired.

@kahgoh
Copy link
Contributor Author

kahgoh commented Oct 20, 2023

I've just pushed a commit to fix to the fork repo, although I notice the commit or changes hasn't appeared here. Can this PR be reopened?

- Mark second to last tests xtest
- Remove unnecessary exp import
- Use global constants for "A", "Z", "a" and "z"
- Add instructions.append.md
@keiravillekode
Copy link
Contributor

With extra commits, they appear when the PR is reopened. LGTM

(Once I rebased with a closed PR instead of adding extra commits, that messed things up and the PR couldn't be reopened.)

@ErikSchierboom
Copy link
Member

@keiravillekode Could you re-review?

@ErikSchierboom ErikSchierboom merged commit 894d7ba into exercism:main Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants