Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hello World]: Added comment to stub and Instruction Append #78

Merged
merged 3 commits into from Oct 31, 2023

Conversation

BethanyG
Copy link
Member

Please see this forum discussion for details.

Added a comment to warn students that they need to adjust the export line in the stub file:

  (func (export "hello") (result i32 i32)
    (i32.const 64) (i32.const 14)
  )

"Goodby, Mars!" is 14, but "Hello, World!" is 13, so if (i32.const 14) is not changed, the student won't pass the tests.

Also added a caution level instruction append to alert students.

Conversely, the stub can be altered so that it is already 13 -- but then it won't match "Goodby, Mars!".

@iHiD
Copy link
Member

iHiD commented Oct 30, 2023

Thank you! 💙

@ErikSchierboom You happy with this - if so, let's merge it before Nov starts pls! :)

@bushidocodes
Copy link
Contributor

LGTM. A tiny nit is that "Web Assembly" should be written as one word "WebAssembly." I've approved because it's not worth delaying this given how close we are to the start of the month.

Corrected Web Assembly --> WebAssembly per code review comment.
@BethanyG
Copy link
Member Author

@bushidocodes -- corrected. Thanks for pointing it out! 😄

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@BethanyG
Copy link
Member Author

@ErikSchierboom @bushidocodes - ready for merge (I think!).

@ErikSchierboom ErikSchierboom merged commit f73bd84 into exercism:main Oct 31, 2023
2 checks passed
@ErikSchierboom
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants