-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basics for eslint support #174
Conversation
sourceType: 'module', | ||
}, | ||
plugins: ['jest', 'react', '@typescript-eslint'], | ||
rules: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from this empty ruleset, all of this looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(FWIW, if you have bugs with error on indentation, and then prettier "not" doing it right, manually add
"indent": 0,
"@typescript-eslint": 0
)
They might have fixed it by now, so don't add this until/less you get issues.
@ErikSchierboom Should this get merged? |
96ee6f5
to
f27a658
Compare
Closes #164