Switch to Rails 6.1 #365
Merged
Switch to Rails 6.1 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
requested review from
kntsoriano and
ErikSchierboom
and removed request for
kntsoriano
iHiD
commented
Dec 11, 2020
| @@ -31,7 +31,7 @@ class Mentor::ReplyToDiscussionTest < ActiveSupport::TestCase | |||
| "foobar" | |||
| ) | |||
| assert_equal 1, user.notifications.size | |||
| notification = user.notifications.first | |||
| notification = Notification.where(user: user).first | |||
There was a problem hiding this comment.
These are from me working on getting strict_loading working. It's problematic with FactoryBot so I've stopped for now. But these are still fine to merge.
There was a problem hiding this comment.
It basically causes an exception if an n+1 might happen.
kntsoriano
reviewed
Dec 13, 2020
| @@ -5,9 +5,10 @@ class Create | |||
| initialize_with :solution, :submission | |||
|
|
|||
| def call | |||
| time = Time.now.utc.to_s(:db) | |||
There was a problem hiding this comment.
NOW() doesn't work with the latest version of MySQL on mac for some reason.
kntsoriano
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.