Add previous / next iteration buttons #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
approved these changes
Jan 13, 2021
iHiD
approved these changes
Jan 13, 2021
Comment on lines
+27
to
+42
| <button | ||
| type="button" | ||
| aria-label="Go to previous iteration" | ||
| onClick={() => onClick(iterations[currentIndex - 1])} | ||
| disabled={iterations[0] === current} | ||
| > | ||
| Previous | ||
| </button> | ||
| <button | ||
| type="button" | ||
| aria-label="Go to next iteration" | ||
| onClick={() => onClick(iterations[currentIndex + 1])} | ||
| disabled={iterations[iterations.length - 1] === current} | ||
| > | ||
| Next | ||
| </button> |
There was a problem hiding this comment.
This is fine but this is technically pagination and thus it could be implemented as:
<a
href={urlThatGoesThere}
onClick={handlerThatPreventsDefaultAndGoesThere}
rel="next"That way, users can mid or right click and store the url to the iteration.
Also, you probably want to focus the new/linked iteration after "opening" it.
There was a problem hiding this comment.
@SleeplessByte I'd like to do this as well. What's a good approach to update the URL link once we click on the button?
I'm merging this PR in for now, and I'll open a separate PR to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.