Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all ExerciseWidgets to clickable links #6209

Merged
merged 8 commits into from
Sep 28, 2023

Conversation

dem4ron
Copy link
Member

@dem4ron dem4ron commented Sep 19, 2023

https://forum.exercism.org/t/missing-making-the-grade/7037

This PR converts all ExerciseWidgets into clickable links, removes the render_as_link prop, and deletes the unused SolutionActivity class along with its associated tests.

These should stay the same (visually):
Screenshot 2023-09-22 at 15 02 24 Screenshot 2023-09-22 at 15 02 41 ##### These should be clickable links:
Screen.Recording.2023-09-22.at.15.07.12.mov
4px gap added to .prereqs:
Screenshot 2023-09-22 at 15 43 07 Screenshot 2023-09-22 at 15 43 38
Recommended && locked exercise has a gradient border:
Screenshot 2023-09-22 at 15 40 07

@dem4ron dem4ron force-pushed the clickable-link-locked-exercises branch from 2a10098 to f278d89 Compare September 21, 2023 09:36
@dem4ron dem4ron marked this pull request as ready for review September 22, 2023 14:13
@iHiD iHiD merged commit 525a8fa into main Sep 28, 2023
38 checks passed
@iHiD iHiD deleted the clickable-link-locked-exercises branch September 28, 2023 16:08
@iHiD
Copy link
Member

iHiD commented Sep 28, 2023

Nice work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants