Work out TrainingData Dashboard UI #6452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
reviewed
Nov 6, 2023
| @@ -33,6 +29,9 @@ def tracks_request | |||
| options: { stale_time: 0 } | |||
| } | |||
| end | |||
|
|
|||
| DEFAULT_STATUS = :untagged | |||
| private_constant :DEFAULT_STATUS | |||
There was a problem hiding this comment.
@dem4ron Constants tend to go at the bottom of the file if they're private and the top if they're public.
iHiD
reviewed
Nov 6, 2023
| iconUrl: 'ruby_icon_url', | ||
| highlightjsLanguage: 'ruby' | ||
| icon_url: 'ruby_icon_url', | ||
| highlightjs_language: 'ruby' |
iHiD
added a commit
that referenced
this pull request
Nov 6, 2023
* Add types, setup mutation, rearrange things * More renames * Remove redundant type * Adjust LeftPane * Adjust code_tagger DS * Format classNames of ResultsZone * Adjust things, css * Refactor things * Rename links * Work out TrainingData Dashboard UI (#6452) * Refactor, add types, align things * Get tests passing * Start adding endpoints * Rename folder * Rename another folder * Fix tests --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
iHiD
added a commit
that referenced
this pull request
Nov 6, 2023
* Basic setup * Add most of the components * Move component to a show * Remove unused components * Add dashboard, list components, move external content into an external file * Rename things * Fix * Further renames * Fix typo * Add stuff * Array not object * Rename module * More renames * TrackTagsTuple -> CodeTagsSample * Add types, setup mutation, rearrange things (#6451) * Add types, setup mutation, rearrange things * More renames * Remove redundant type * Adjust LeftPane * Adjust code_tagger DS * Format classNames of ResultsZone * Adjust things, css * Refactor things * Rename links * Work out TrainingData Dashboard UI (#6452) * Refactor, add types, align things * Get tests passing * Start adding endpoints * Rename folder * Rename another folder * Fix tests --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
iHiD
added a commit
that referenced
this pull request
Nov 7, 2023
* Basic setup * Add most of the components * Move component to a show * Remove unused components * Add dashboard, list components, move external content into an external file * Rename things * Fix * Further renames * Fix typo * Add stuff * Array not object * Rename module * More renames * TrackTagsTuple -> CodeTagsSample * Add types, setup mutation, rearrange things (#6451) * Add types, setup mutation, rearrange things * More renames * Remove redundant type * Adjust LeftPane * Adjust code_tagger DS * Format classNames of ResultsZone * Adjust things, css * Refactor things * Rename links * Work out TrainingData Dashboard UI (#6452) * Refactor, add types, align things * Get tests passing * Start adding endpoints * Rename folder * Rename another folder * Fix tests --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
iHiD
added a commit
that referenced
this pull request
Nov 7, 2023
* Basic setup * Add most of the components * Move component to a show * Remove unused components * Add dashboard, list components, move external content into an external file * Rename things * Fix * Further renames * Fix typo * Add stuff * Array not object * Rename module * More renames * TrackTagsTuple -> CodeTagsSample * Add types, setup mutation, rearrange things (#6451) * Add types, setup mutation, rearrange things * More renames * Remove redundant type * Adjust LeftPane * Adjust code_tagger DS * Format classNames of ResultsZone * Adjust things, css * Refactor things * Rename links * Work out TrainingData Dashboard UI (#6452) * Refactor, add types, align things * Get tests passing * Start adding endpoints * Rename folder * Rename another folder * Fix tests --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
ErikSchierboom
added a commit
that referenced
this pull request
Nov 21, 2023
* Add some ML Training scaffolding * Add code tagger page (#6445) * Basic setup * Add most of the components * Move component to a show * Remove unused components * Add dashboard, list components, move external content into an external file * Rename things * Fix * Further renames * Fix typo * Add stuff * Array not object * Rename module * More renames * TrackTagsTuple -> CodeTagsSample * Add types, setup mutation, rearrange things (#6451) * Add types, setup mutation, rearrange things * More renames * Remove redundant type * Adjust LeftPane * Adjust code_tagger DS * Format classNames of ResultsZone * Adjust things, css * Refactor things * Rename links * Work out TrainingData Dashboard UI (#6452) * Refactor, add types, align things * Get tests passing * Start adding endpoints * Rename folder * Rename another folder * Fix tests --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Remove logger * Clean up Dashboard * Read from a real sample * Remove tiny index files * Clean up DashboardHeader * Convert code to files * Improve logic * Make tabs more dynamic, adjust link type * Add locking behaviour * Adjust types, camelize keys * Add params, statuses * Fix the tests * Tidying styling * Add all tags * react-query -> tanstack, update yarn lock * Adjust `all_tags` * Pass down all_tags * Pass down things, set default values * Add missing endpoint, restructure data * Add training_data_root path * Fix http method, fix `update_tags` * Fix wrong linkname * Add redirect logic * Update trainer? method * Verify trainer of tag updating and add tests * Add serializers for code tags samples * Remove order param * Start work on retrieving code samples * UI adjustments, add Dashboard view to training_Data/dashboard/index * Allow retrieving samples * Add link to edit code tags sample * Reduce indentation * Convert sample retrieval to filter * Guard track trainer * Update tab names / statuses * Switch to new statuses * Add training data API request * Load tracks * Add non-optimized trainer * Sort out track filter * Adjust Tabs * Refactor TaggableCodeList, improve code, rename css classes * Add trainer and rep to user track (#6520) * Add trainer and reputation to user_track * Add command to update user_track reputation * Update user_track reputation in migration * Update user_track reputation when new reputation token is created * Add command to update trainer field of user_track * Toggle trainer status * Detect track trainer * Guard trainer * Move trainer to user_data * Update eligibility checks * Opt-in to becoming a trainer * Minor tweak * Remove unused code * Re-enable check * Refactor * Update app/views/training_data/external/_locked.html.haml Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Update app/views/training_data/external/index.html.haml Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Update app/views/training_data/external/_locked.html.haml Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Update app/models/user.rb Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Update app/models/user.rb Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Move constant * Move update trainer * Fix rubocop * Fix unit tests * Simplify * Revert changes --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Add bottom nav, start playing with tag-filter's styles * Add Training Hub submenu * Adjust description text * Tweak selector styles, rename PlaceholderStuff, * Sync track tags * Fix code tagger * Try and fix issues * Add status * Update status * Fix next * Add locking * Minor tweak * Fix * Add tests for retrieving next * Add tests for updating tags * Update app/commands/user_track/update_reputation.rb Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Remove unneeded check * Move trainer filter to application controller * Minor refactoring * Disable training hub menu item * Switch logic around * Simplify * Shorten name * Remove stubbable method * Retry locking next sample * Simplify trainer guard * Fix rubocop * Be explicit about status * Fix tests * Add tests for external controller * Redirect via ensure_trainer! * Add tests for dashboard controller * Fix link and name of tab * Apply suggestions from code review * Safe to overrride * Refactor * Revert * Fix test: --------- Co-authored-by: Aron Demeter <66035744+dem4ron@users.noreply.github.com> Co-authored-by: dem4ron <demaaron88@gmail.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
iHiD
added a commit
that referenced
this pull request
Nov 22, 2023
[skip ci] * Add some ML Training scaffolding * Add code tagger page (#6445) * Basic setup * Add most of the components * Move component to a show * Remove unused components * Add dashboard, list components, move external content into an external file * Rename things * Fix * Further renames * Fix typo * Add stuff * Array not object * Rename module * More renames * TrackTagsTuple -> CodeTagsSample * Add types, setup mutation, rearrange things (#6451) * Add types, setup mutation, rearrange things * More renames * Remove redundant type * Adjust LeftPane * Adjust code_tagger DS * Format classNames of ResultsZone * Adjust things, css * Refactor things * Rename links * Work out TrainingData Dashboard UI (#6452) * Refactor, add types, align things * Get tests passing * Start adding endpoints * Rename folder * Rename another folder * Fix tests --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Remove logger * Clean up Dashboard * Read from a real sample * Remove tiny index files * Clean up DashboardHeader * Convert code to files * Improve logic * Make tabs more dynamic, adjust link type * Add locking behaviour * Adjust types, camelize keys * Add params, statuses * Fix the tests * Tidying styling * Add all tags * react-query -> tanstack, update yarn lock * Adjust `all_tags` * Pass down all_tags * Pass down things, set default values * Add missing endpoint, restructure data * Add training_data_root path * Fix http method, fix `update_tags` * Fix wrong linkname * Add redirect logic * Update trainer? method * Verify trainer of tag updating and add tests * Add serializers for code tags samples * Remove order param * Start work on retrieving code samples * UI adjustments, add Dashboard view to training_Data/dashboard/index * Allow retrieving samples * Add link to edit code tags sample * Reduce indentation * Convert sample retrieval to filter * Guard track trainer * Update tab names / statuses * Switch to new statuses * Add training data API request * Load tracks * Add non-optimized trainer * Sort out track filter * Adjust Tabs * Refactor TaggableCodeList, improve code, rename css classes * Add trainer and rep to user track (#6520) * Add trainer and reputation to user_track * Add command to update user_track reputation * Update user_track reputation in migration * Update user_track reputation when new reputation token is created * Add command to update trainer field of user_track * Toggle trainer status * Detect track trainer * Guard trainer * Move trainer to user_data * Update eligibility checks * Opt-in to becoming a trainer * Minor tweak * Remove unused code * Re-enable check * Refactor * Update app/views/training_data/external/_locked.html.haml Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Update app/views/training_data/external/index.html.haml Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Update app/views/training_data/external/_locked.html.haml Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Update app/models/user.rb Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Update app/models/user.rb Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Move constant * Move update trainer * Fix rubocop * Fix unit tests * Simplify * Revert changes --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> * Add bottom nav, start playing with tag-filter's styles * Add Training Hub submenu * Adjust description text * Tweak selector styles, rename PlaceholderStuff, * Show correct error message * Adjust ApiError, dont export it twice * Further simplify * Remove ApiError for now * Restore fetch-json * Use already existing solution * Remove `app/views/training_data/dashboard` folder and its controller * Remove dashboard test * Revert "Remove dashboard test" This reverts commit b34294c. * Revert "Remove `app/views/training_data/dashboard` folder and its controller" This reverts commit bd01ac1. * Remove dashboard folder only * Remove `create_table "add_uuid_to_code_tags_samples"` from `schema.rb` --------- Co-authored-by: Jeremy Walker <jez.walker@gmail.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.