phone-number: Correct test to more-than check vs equal-to check #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
reviewed
Mar 12, 2017
There was a problem hiding this comment.
thanks, change is good.
can we make this version 1.0.1? description change is defined in #673 as increasing patch level
can we get exercise name in commit message? as https://github.com/exercism/x-common/blob/master/CONTRIBUTING.md#pull-request-guidelines requests
kotp
changed the title
|
Thanks for the heads-up @petertseng (and the title help @kotp). Just to note that I did take a quick glance at the CONTRBUTING.md but found it very long to try and find the relevant information in (i.e. the bit Peter linked)... Maybe that, or something like it, could be split out to the same directory and linked to to make it easier to find? Just a suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #608