bracket-push: Add new exercise; README/test-exercise: no hyphens in module names #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ceylon doesn't tend to like these: ``` $ ceylon compile bracket-push ceylon compile: Invalid module name or source file: bracket-push Module names should not contain any version part. ``` Despite the fact that I didn't give a version part, I think the dash causes it to be interpreted that way. It works if I make it bracketpush, so I'll just do that. I looked at https://herd.ceylon-lang.org and while some modules there have dashes in the name, they are all the "Legacy Jar" format, so I imagine this is not replicable.
As discovered (see README change removing dash from module name), module names with dashes don't seem to be accepted.
petertseng
force-pushed
the
bracket-push
branch
from
e732d49
to
a8c40e7
Compare
petertseng
commented
Jan 15, 2017
| if (opens.contains(c)) { | ||
| expectedOpens.push(c); | ||
| } else if (exists open = openFor[c]) { | ||
| if (exists last = expectedOpens.pop(), last == open) { |
There was a problem hiding this comment.
empty if makes me uncomfortable.
There was a problem hiding this comment.
Fixed, using expectedOpens.pop() else '!'
petertseng
commented
Jan 15, 2017
| @@ -0,0 +1,4 @@ | |||
| module bracketpush "1.0" { | |||
| import "ceylon.collection" "1.3.1"; | |||
petertseng
force-pushed
the
bracket-push
branch
from
a8c40e7
to
416b559
Compare
petertseng
force-pushed
the
bracket-push
branch
from
416b559
to
6954c7d
Compare
petertseng
added a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Jan 15, 2017
Student's only has ceylon.test, example's has whatever it needs. This pattern has already been used in sieve (exercism#16) and bracket-push (exercism#13) anyway, so it needs to be documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.