Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exercises(linked-list): test: fix for Zig 0.12.0-dev #366

Merged
merged 1 commit into from Jan 8, 2024

Conversation

yctai1994
Copy link
Contributor

Fix the following compiler warning when doing the practice in the CLI.

version: zig-v0.12.0-dev.2059+42389cb9c

linked-list/test_linked_list.zig:71:9: error: local variable is never mutated
    var list = List{};
        ^~~~

Copy link

github-actions bot commented Jan 8, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 8, 2024
@ee7
Copy link
Member

ee7 commented Jan 8, 2024

The Zig track currently supports only Zig 0.11.0:

## Zig version
Exercism currently supports Zig 0.11.0 (released on 2023-08-04) only.
An exercise may be compatible with a different Zig version, but that isn't guaranteed.
Zig has not yet reached version 1.0, and breaking changes are common.

However, I'm happy to improve compatibility with Zig master when it doesn't break support for 0.11.0, so I'll merge this - thanks. I think it was the only test case on the track that didn't support Zig master.

@ee7 ee7 reopened this Jan 8, 2024
@ee7 ee7 self-assigned this Jan 8, 2024
@yctai1994
Copy link
Contributor Author

yctai1994 commented Jan 8, 2024

The Zig track currently supports only Zig 0.11.0:

Oh, ok, thanks!

I think it was the only test case on the track that didn't support Zig master.

Yeah, it took me a couple of days to sweep all the practices on this track. This is the only one that isn't compatible with the nightly version.

@ee7 ee7 merged commit c531537 into exercism:main Jan 8, 2024
8 checks passed
@ee7 ee7 changed the title exercises(linked-list): fix the compiler warning exercises(linked-list): test: fix for Zig 0.12.0-dev Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants