Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer further build profiles #3386

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

adamretter
Copy link
Member

@line-o If you don't need the distribution archives, e.g. when testing/hacking locally. Then with this PR, setting -P !build-dist-archives can save ~40 seconds on each build (at least on my machine).

@adamretter adamretter added the enhancement new features, suggestions, etc. label Apr 22, 2020
@adamretter adamretter added this to the eXist-5.2.1 milestone Apr 22, 2020
@adamretter adamretter requested a review from a team April 22, 2020 09:46
adamretter added a commit to adamretter/documentation that referenced this pull request Apr 22, 2020
@line-o
Copy link
Member

line-o commented Apr 22, 2020

@adamretter You heard me :) Thanks!
Two additional profiles are added, which should be mentioned here for completeness:

  • concurrency-stress-tests and
  • micro-benchmarks

@adamretter
Copy link
Member Author

adamretter commented Apr 22, 2020

You heard me :) Thanks!

@line-o I always "hear you", we just have different priorities sometimes! :-p

@line-o
Copy link
Member

line-o commented Apr 22, 2020

@adamretter the other two are not executed on mvn package, correct?
But, as I understand it, the slim build is done by: mvn package -P !build-dist-archives

@line-o
Copy link
Member

line-o commented Apr 22, 2020

Could you add an example how to trigger the other two? @adamretter

@adamretter
Copy link
Member Author

the other two are not executed on mvn package, correct?

That's incorrect.

@line-o
Copy link
Member

line-o commented Apr 23, 2020

@adamretter so why were the other two moved from modules to profiles?

@adamretter
Copy link
Member Author

@line-o Maybe best if you have a read-up on Maven build configurations. Sonatype produce some PDFs which are not a bad starting point, you can find them via Google.

@joewiz joewiz merged commit a2688c2 into eXist-db:develop Apr 26, 2020
@line-o
Copy link
Member

line-o commented Apr 26, 2020

I ended up testing a lot of different calls to mvn package and ended up with

mvn -T2C clean package -DskipTests -Ddependency-check.skip=true -Ddocker=false -P \!build-dist-archives,\!mac-dmg-on-mac,\!codesign-mac-dmg,\!mac-dmg-on-unix,\!installer,\!concurrency-stress-tests,\!micro-benchmarks

I would suggest to create an alias for that as it is impossible to type and remember. But at least this saves a lot of precious time.

@eXist-db eXist-db deleted a comment from line-o Apr 26, 2020
@eXist-db eXist-db deleted a comment from line-o Apr 26, 2020
@eXist-db eXist-db deleted a comment from line-o Apr 26, 2020
@eXist-db eXist-db deleted a comment from line-o Apr 26, 2020
adamretter added a commit to adamretter/exist that referenced this pull request May 13, 2020
…sabled with profile `skip-build-dist-archives`.

Fixes a regression introduced in eXist-db#3386
@adamretter adamretter deleted the refactor/further-profiles branch September 14, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new features, suggestions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants