Feature/add missing fn trace #3597
Conversation
| @@ -38,40 +39,53 @@ | |||
| */ | |||
| public class FunTrace extends BasicFunction { | |||
|
|
|||
| public final static FunctionSignature signature = | |||
| public final static FunctionSignature[] signatures = { | |||
There was a problem hiding this comment.
Any interest in using the newer FunctionDSL approach? It has some advantages...
There was a problem hiding this comment.
I was in doubt to apply that pattern, but was not sure how to start....
There was a problem hiding this comment.
yes lets do that, do you have a good sample for it?
There was a problem hiding this comment.
I think the CacheModule isn't a bad example.
There was a problem hiding this comment.
@dizzzz Thank you for helping eXist advance toward full coverage of the XQuery 3.1 spec! I ran this PR against https://github.com/w3c/qt3tests/blob/master/fn/trace.xml, using https://github.com/eXist-db/exist-xqts-runner (commands: sbt clean compile, sbt assembly, and target/scala-2.13/exist-xqts-runner-assembly-1.0.0.jar -ts fn-trace). With this PR, eXist passes 24 of the 27 tests for fn:trace (see fn-trace-junit-data-PR-3597.zip). Surprisingly, develop passes 25 of the 27 tests (see fn-trace-junit-data-develop.zip). However, scanning through the failures, it seems to me that none of them appear to be consequential.
|
|
|
updated description @adamretter @joewiz |
|
It gives more structure than the original WoW I guess. I will start using it from now :-) |
|
@dizzzz What does "WoW" stand for? I also just pushed a very small improvement ;-) |
|
Way Of Working :-P |
Thanks to @dizzzz's eXist-db/exist#3597
Adding fn:trace#1 function
Testcases are included