Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sig updater loops and other few lil things #65

Closed
ghost opened this issue Nov 14, 2015 · 5 comments
Closed

Sig updater loops and other few lil things #65

ghost opened this issue Nov 14, 2015 · 5 comments

Comments

@ghost
Copy link

ghost commented Nov 14, 2015

Hi there, my corp put up a beta server to give this tool a try but I'm not the one hosting it so I don't have access to the logs and reports in general.

Take this as a quick feedback on the first few hours of use. I must say I was rather impressed, everything works pretty well or at least it's not utterly broken which is already something for the state of the early beta. I spotted only one major problem and it's about the sig updater. It basically loops indefinitely and doesn't add the sigs. Selecting and "deleting all" gave me a msg of "1 sig to delete, confirm?" kind of msg, and this went on for a while untill for some reason they all got deleted finally. Problem is during and after this looping the tool loses track of my position. I'm basically stuck in the system where the sig updater looped and this is pretty bad. Closing the browser and re-opening it doesn't fix the problem as long as the sig updater is looping. Also, cpu spike on my task manager. I tried to copy and paste the log output in my client but it didn't work, same with the "download .cvs" at least I didn't find it. It was a problem updating client data of some sort though and I suppose it is mostly related to the IGB actually because I had pathfinder running on win too and at least it did add the new systems I was jumping into even if it still showed me on the "one in loop". This was not happening in the IGB.

Other lil issue spotted: not sure exactly why and when but sometimes it doesn't create the connections when jumping in a new hole, especially when you're running a private map aside the master one. It looks like it updates only the active one and then adds the system on the other one (no connection though) if you switch tab for a while. This means if you stay on a private map for say 5 jumps, those won't be recorded on the master one. It seems also like it loses the tracking of my position on the master map if I hop into a private one and I jump off system. I still can add the systems manually but it's a bit awkward.

Another small thing not working as intended is the poke on rally points. I'm not sure what it should do but I don't get any notification nor ping in windows when me or someone else adds a rally point in a shared map. I can see the flashy system in the win browser but no notification/alarm.

Ok sorry for the wall of text, hope it was useful. The tool is pretty awesome, have a nice day and code harder o7

👍

@exodus4d
Copy link
Owner

Thanks for your feedback! Ill check your points and hopefully fix them within the next releases ;)

@ghost
Copy link
Author

ghost commented Nov 15, 2015

Ok I don't know if you want me to use the eve-o forums for feedback and such but I'll keep on here for these minor bug reports.

First is still about the sig updater: http://imgur.com/j9VdkXG
As you see only one sig is not fully scanned but it won't add the other two in no way. Tried deleting them all, adding them manually, deleting the single one and adding all again.... nope, it doesn't record them, always those 2.

Second is about Miakie: http://imgur.com/q4JSz2M
It's an highsec system, it's shown as 0.5 sec in the system window (correct) but it's marked as lowsec in the map and in the sys window too.

Third is a bit harder to explain: http://i.imgur.com/RycNoE5.jpg
For some reason sometimes when it adds a new system it creates and suddently delete the connection. I can add it manually but whenever I touch the system icon to drag it around it becomes red and I didn't find any way to remove that background. It's as if someone selected the systems but they are not. In the pic above I haven't dragged or moved around only two system: C3 J164034 and HS Vahunomi. Hope it's clear.

Mkay, back to scanning :D

exodus4d added a commit that referenced this issue Nov 16, 2015
…gnature information will now only change if "real" data has changed and not the "updateCharacter", Added autofocus to sigReader textarea field.
@exodus4d
Copy link
Owner

Fixed so far:

  • Signature count in "delete all" dialog
  • Infinite "looping" in the Signature table, after added multiple sigs
  • Some minor improvements in the save() function for signatures
  • Added "autofocus" to the <textarea> in "signature reader" dialog

@exodus4d
Copy link
Owner

Thanks for your feedback :)

"Miakie" system

I have fixed this. The problem was a "trueSec" rounding problem 0.486 is a HS system, even if it is < 0.5

Rally point "poke"

Yeah i know, its not fully implemented at this point, I´m on it ;)

Signature updater

You are talking about the signatures IRL and ORT right?

  • IRL looks good to me, it is marked as "wormhole" in the table. The wormhole type (unknown) can not automaticalls be added by copy&paste to the table, The wormhole information is not available in the D-Scan window :( This must be added manually.
  • ORT This looks "bad" to me. The Gas site "Bountiful Frontier ...." schould automatically be added to the table. Ill check this
Map tracking

The map "tracking" is not a bug. It works like intended :)
The problem with auto-updateing/adding new systems to all maps you have access is, that private maps are supposed to be private. If you are watching a private map, this information on this map is just for you, not for any corp/ally member.

Even if there is a corporation or ally map open, new systems should not automatically be added to all your open maps. Think about a large 0.0 ally with a great number of active players. If everyone would add new systems to an alliance map, this would not be handy.

All other fixed in here will go live with v0.0.16 next week.

@exodus4d exodus4d added this to the v 0.0.16 BETA milestone Nov 17, 2015
@exodus4d exodus4d self-assigned this Nov 17, 2015
@exodus4d exodus4d mentioned this issue Nov 18, 2015
@exodus4d
Copy link
Owner

v0.0.16 is online. Ever bug in here except the auto-deleted connections should be fixed. Ill close this issue and create a new issue for that.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant