Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw HTML content so example can be generated with Rails 7.1+ #189

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Conversation

exoego
Copy link
Owner

@exoego exoego commented Mar 25, 2024

Fixes #190

Before Rails 7.1, HTML response body were simply string.
Rails 7.1 introduced Nokogiri parser to HTML response body, which is not supported in rspec-openapi.

Thi

Gemfile Fixed Show fixed Hide fixed
Gemfile Fixed Show fixed Hide fixed
Gemfile Fixed Show fixed Hide fixed
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (bd48dae) to head (0befb74).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files          14       14           
  Lines         502      503    +1     
  Branches      116      117    +1     
=======================================
+ Hits          487      488    +1     
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exoego exoego changed the title Handle Nokogiri HTML Use raw HTML content so example can be generated with Rails 7.1+ Mar 25, 2024
@exoego exoego marked this pull request as ready for review March 25, 2024 07:33
@exoego exoego added the bug Something isn't working label Mar 25, 2024
@exoego exoego merged commit 7a98af4 into master Mar 25, 2024
11 checks passed
@exoego exoego deleted the html branch March 25, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails 7.1 transforms request.response_body to Nokogiri class if it is HTML
1 participant