Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove content field if no content #193

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix: Remove content field if no content #193

merged 2 commits into from
Mar 25, 2024

Conversation

exoego
Copy link
Owner

@exoego exoego commented Mar 25, 2024

Empty content is injected ...
image

However, content should not be added for no content response, according to

https://swagger.io/docs/specification/describing-responses/
image

@exoego exoego added the bug Something isn't working label Mar 25, 2024
@exoego exoego changed the title Fix head (no-content) reponse Fix empty content is injected if no-content Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (7a98af4) to head (954b60b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   97.01%   97.02%   +0.01%     
==========================================
  Files          14       14              
  Lines         503      505       +2     
  Branches      117      119       +2     
==========================================
+ Hits          488      490       +2     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exoego exoego changed the title Fix empty content is injected if no-content fix: Remove content field if no content Mar 25, 2024
@exoego exoego marked this pull request as ready for review March 25, 2024 07:43
@exoego exoego merged commit efcca3b into master Mar 25, 2024
13 checks passed
@exoego exoego deleted the fix-no-content branch March 25, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant