String keys and Symbol keys mixed up, leading to invalid schema merge #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 97.02% 97.09% +0.06%
==========================================
Files 14 15 +1
Lines 505 516 +11
Branches 119 125 +6
==========================================
+ Hits 490 501 +11
Misses 15 15 ☔ View full report in Codecov by Sentry. |
exoego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #196, I found string and symbols are mixed up.
String keys come from the base file (
YAML.safe_load(File.read(@path))) and Symbol keys come from the generate specs.Since String != Symbol, merge is buggy, as seen in c941c62
This PR symbolizes all keys during processing.
Keys are transformed to String back when dumping into YAML file.