Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont' log missing Rails/Hanami unless DEBUG #217

Merged
merged 5 commits into from Apr 17, 2024
Merged

Dont' log missing Rails/Hanami unless DEBUG #217

merged 5 commits into from Apr 17, 2024
+17 −13

Conversation

exoego
Copy link
Owner

@exoego exoego commented Apr 17, 2024

Mod of #216

bf4 and others added 2 commits April 16, 2024 22:50
@bf4
fix: warn when Hanami or Rails are not detected
0c2575c 
I started noticing "Hanami not detected" lately.  I'm not sure exactly what to recommend here, perhaps only output anything when `ENV["CI"] == "true"` or something like that.. but I think preferring warn -> stderr over puts -> stdout is a good start to lower the shoutiness of it.
@exoego
Hide these under flag
d40c398
@exoego exoego added the enhancement New feature or request label Apr 17, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 17, 2024
View reviewed changes
lib/rspec/openapi.rb Fixed Show fixed Hide fixed
lib/rspec/openapi.rb Fixed Show fixed Hide fixed
lib/rspec/openapi.rb Fixed Show fixed Hide fixed
lib/rspec/openapi.rb Fixed Show fixed Hide fixed
@exoego exoego changed the title Patch 3 Dont' log missing Rails/Hanami unless DEBUG Apr 17, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 97.06%. Comparing base (3394219) to head (3834b8d).

❗ Current head 3834b8d differs from pull request most recent head f2af288. Consider uploading reports for the commit f2af288 to get more accurate results

Files Patch % Lines
lib/rspec/openapi.rb 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   97.22%   97.06%   -0.16%     
==========================================
  Files          20       20              
  Lines         612      614       +2     
  Branches      133      137       +4     
==========================================
+ Hits          595      596       +1     
- Misses         17       18       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exoego exoego merged commit dc14c65 into master Apr 17, 2024
11 checks passed
@exoego exoego deleted the patch-3 branch April 17, 2024 06:28
@exoego exoego mentioned this pull request Apr 17, 2024
Closed
@exoego exoego added this to the v0.18.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@exoego @bf4