Bugfix timers dropping #1218
Merged
Bugfix timers dropping #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exokit optimizes the timers allocation to reuse array slots. Additionally, the timer ids returned to
windowfromsetTimeout/setIntervalneed to be integers starting at1-- contrary to node which returns objects.The bug here was that we were blindly incrementing the returned id in all cases, which allowed it to collide. This meant that
clearTimeoutcould, for example, clear the wrong timeout, leading to really weird bugs.Partial fix for #1217.