Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas2d context reuse #1335

Merged
merged 13 commits into from
Jul 22, 2019
Merged

Canvas2d context reuse #1335

merged 13 commits into from
Jul 22, 2019

Conversation

avaer
Copy link
Member

@avaer avaer commented Jul 19, 2019

Fixes #1334.

With this PR, windows now only create a single canvas2d Skia backing context for the lifetime of the window, and this context is not destroyed when any logical CanvasRenderingContext2D is destroyed.

@avaer
Copy link
Member Author

avaer commented Jul 20, 2019

Tested this and it works on Canvas2d-heavy sites.

@avaer avaer merged commit 5354870 into master Jul 22, 2019
@avaer avaer deleted the init-window-2d branch July 22, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canvas 2D uses too many contexts
1 participant
@avaer