Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Transaction API syntax improvements #139

Merged
merged 4 commits into from
Oct 9, 2018
Merged

WIP: Transaction API syntax improvements #139

merged 4 commits into from
Oct 9, 2018

Conversation

boguslavsky
Copy link
Contributor

@boguslavsky boguslavsky commented Oct 9, 2018 •
edited
Loading

MethodnewMessage has been renamed into newTransaction to avoid confusion in terms.
Now Transaction is extended fromMessage class.

@coveralls
Copy link

coveralls commented Oct 9, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 93.189% when pulling 81df99e on boguslavsky:tx-syntax-changes into 2a53c76 on exonum:master.

rename newMessage to newTransaction, isInstanceofOfNewMessage to isTr…
74d9b54 
…ansaction, isInstanceofOfNewArray to isNewArray
@boguslavsky boguslavsky merged commit c43ecea into exonum:master Oct 9, 2018
@boguslavsky boguslavsky deleted the tx-syntax-changes branch October 9, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qvantor qvantor qvantor approved these changes

@KateNegrienko KateNegrienko KateNegrienko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boguslavsky @coveralls @qvantor @KateNegrienko