Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in exonum-merkledb #1303

Merged
merged 6 commits into from
May 1, 2019
Merged

Conversation

alekseysidorov
Copy link
Contributor

  • Restore snapshot method in ServiceContext.

Definition of Done

  • There are no TODOs left in the merged code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has proper documentation
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #1303 into master will increase coverage by <.01%.
The diff coverage is 94.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   93.18%   93.18%   +<.01%     
==========================================
  Files         162      162              
  Lines       24949    24899      -50     
==========================================
- Hits        23248    23202      -46     
+ Misses       1701     1697       -4
Impacted Files Coverage Δ
exonum/src/blockchain/service.rs 72.97% <ø> (ø) ⬆️
components/merkledb/src/proof_map_index/proof.rs 94.56% <ø> (ø) ⬆️
exonum/src/helpers/fabric/maintenance.rs 27.02% <0%> (+0.71%) ⬆️
testkit/tests/counter/counter.rs 98.76% <100%> (ø) ⬆️
...sts/inflating_currency/inflating_cryptocurrency.rs 95.37% <100%> (ø) ⬆️
services/time/tests/test_exonum_time.rs 94.73% <100%> (-0.31%) ⬇️
services/configuration/src/schema.rs 96.8% <100%> (ø) ⬆️
examples/timestamping/backend/src/schema.rs 96.66% <100%> (ø) ⬆️
services/time/src/schema.rs 91.66% <100%> (ø) ⬆️
components/merkledb/src/db.rs 92.64% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ccae1...c9160f0. Read the comment docs.

@aleksuss aleksuss merged commit 8072b70 into exonum:master May 1, 2019
@alekseysidorov alekseysidorov deleted the merkledb_fixes branch May 29, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants