Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review unwraps in dynamic services [ECR-3419] #1429

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

alekseysidorov
Copy link
Contributor

No description provided.

@alekseysidorov alekseysidorov changed the title Review unwraps in dynamic services Review unwraps in dynamic services [ECR-3419] Aug 19, 2019
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #1429 into dynamic_services will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           dynamic_services    #1429      +/-   ##
====================================================
+ Coverage             92.21%   92.22%   +<.01%     
====================================================
  Files                   177      177              
  Lines                 26048    26047       -1     
====================================================
  Hits                  24021    24021              
+ Misses                 2027     2026       -1
Impacted Files Coverage Δ
exonum/src/runtime/rust/service.rs 81.52% <ø> (ø) ⬆️
exonum/src/runtime/dispatcher/mod.rs 87.62% <100%> (-0.04%) ⬇️
exonum/src/runtime/rust/mod.rs 91.23% <100%> (ø) ⬆️
components/merkledb/src/proof_map_index/tests.rs 98.44% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215e4be...89f5e07. Read the comment docs.

@aleksuss aleksuss merged commit d70389e into exonum:dynamic_services Aug 20, 2019
@alekseysidorov alekseysidorov deleted the ds_review_unwrap branch September 3, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants