Refactor node builders [ECR-4298] #1800
Conversation
slowli
added
discussion 💬
Codecov Report
@@ Coverage Diff @@
## master #1800 +/- ##
=========================================
- Coverage 94.8% 94.8% -0.01%
=========================================
Files 269 269
Lines 42044 42044
=========================================
- Hits 39861 39859 -2
- Misses 2183 2185 +2
Continue to review full report at Codecov.
|
|
|
||
| /// Marker type for artifact deployment without migration support. | ||
| #[derive(Debug)] | ||
| pub struct Simple(()); |
There was a problem hiding this comment.
Why not just Service?
There was a problem hiding this comment.
I think Simple / Migrating dichotomy provides a better description than Service / Migrating. (For one, "simple" and "migrating" are both adjectives 🙃)
There was a problem hiding this comment.
Oh, that is my mistake, I meant that we can just write struct Simple instead of struct Simple(()).
There was a problem hiding this comment.
I wanted Simple / Migrating to be marker types (i.e., not instantiable).
runtimes/rust/src/spec.rs
Outdated
| #[derive(Debug)] | ||
| pub struct Migrating(()); | ||
|
|
||
| /// Deploy specification for a Rust artifact. The spec can include 0 or more instantiated services. |
There was a problem hiding this comment.
Imo zero instead of 0 is more readable.
Overview
This PR refactors node builders in the testkit and the CLI crate, extracting reusable parts into a separate extendable interface.
See: https://jira.bf.local/browse/ECR-4298