Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

build: using egoscale dev branch #13

Merged
merged 29 commits into from
Apr 13, 2018
Merged

build: using egoscale dev branch #13

merged 29 commits into from
Apr 13, 2018

Conversation

greut
Copy link
Contributor

@greut greut commented Dec 14, 2017

Signed-off-by: Yoan Blanc yoan.blanc@exoscale.ch

greut
greut commented Dec 14, 2017
View reviewed changes
api.go Outdated
@@ -45,7 +45,7 @@ func (engine *Engine) FetchNicAndVm() {

func (engine *Engine) ObtainNic(nic_id string) error {

_, err := engine.Exo.AddIpToNic(nic_id, engine.ExoIP.String())
_, err := engine.Exo.AddIpToNic(nic_id, engine.ExoIP.String(), engine.AsyncInfo)
if err != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here err was representing the job creation, and not the addition of the IP to the NIC

@greut greut force-pushed the dev branch 8 times, most recently from 1e95da8 to d8b74e5 Compare January 8, 2018 15:16
@greut
Copy link
Contributor Author

greut commented Jan 8, 2018

No CODECLIMATE_REPO_TOKEN found. A CODECLIMATE_REPO_TOKEN must be specified as an environment variable.

for the code coverage.

greut and others added 9 commits January 11, 2018 16:38
@greut
doc: add example on how to setup using cloud-init (#15)
6bcf32a 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
CoreOS or Container Linux is moving away from cloud-init
37e18e9 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@greut
install using godep for management (#16)
8f06ef5 
* install using godep for management

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

* Update dockerfile

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
add down to ifconfig
32e821e 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
fix: golint issues
ed76b16 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
travis: enable codeclimate
5da9615 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
adapt to egoscale@dev
9bc4def 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
cli: fix codeclimate
3ff037b 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
travis: exoip doesn't need any darwin/win test
aac1a5e 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@greut greut mentioned this pull request Apr 6, 2018
Closed
egoscale: update vendor
8a79093 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Yoan Blanc added 11 commits April 9, 2018 08:54
metadata: do not call ip route
a84ecc7 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
adapt to latest egoscale
1943103 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
go back to linuxkit/ca-certificates
4836630 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
make: add internal registry
dd82811 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
attempt to fix stuff
599356a 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
update list-vms
1454fc2 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
makefile: index generated files
c21f21c 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
global: refactor to feel like reading the godoc
43c848f 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
global: change everything...
2580f9c 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
engine: loading peers from SecurityGroup
e2d6edb 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
codeclimate: be quiet
fd16d42 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
engine: fix tests
7033836 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@greut greut changed the title build: using egoscale dev branch (wip) build: using egoscale dev branch Apr 9, 2018
@greut
Copy link
Contributor Author

greut commented Apr 9, 2018

it's a bit of a messy PR but it works.

Yoan Blanc added 3 commits April 9, 2018 10:53
cmd: listen to SIGTERM,SIGINT
0b31e1e 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
protect the list of Peers with a RWMutex
c75da06 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
upgrade egoscale
9e627ed 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
greut
greut commented Apr 10, 2018
View reviewed changes
engine.go Outdated
for key := range engine.peers {
knownPeers[key] = nil
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sleepy @greut doing lock acquisition into a for loop, 💩

@greut
Copy link
Contributor Author

greut commented Apr 10, 2018

Updating the peers every 100 interval, fixing #6

screenshot from 2018-04-10 10-53-43

@greut greut requested a review from pyr April 10, 2018 08:55
Yoan Blanc added 2 commits April 10, 2018 10:56
engine: remove peers when doing the update
f3dff43 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
remplace int64 by time.Time and time.Duration
3cc97ba 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Yoan Blanc added 2 commits April 13, 2018 11:45
upgrade egoscale
4137b65 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
readme: move cmd to a nicer location
56fc8af 
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@greut greut merged commit 56fc8af into master Apr 13, 2018
@greut greut deleted the dev branch April 16, 2018 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pyr pyr Awaiting requested review from pyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@greut