Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

install using godep for management #16

Merged
merged 2 commits into from
Jan 3, 2018
Merged

install using godep for management #16

merged 2 commits into from
Jan 3, 2018

Conversation

greut
Copy link
Contributor

@greut greut commented Dec 22, 2017

  • godep handles the dependencies versions
  • add labels to the docker file

@vincentbernat
Copy link

I wouldn't commit vendor/ directory. The cons (cluttering) outweight the pros (sources are removed [unlikely] or net unavailable [wouldn't work either]).

@greut greut force-pushed the godep branch 2 times, most recently from 8b4bb97 to bfc256d Compare December 22, 2017 16:27
Yoan Blanc added 2 commits December 22, 2017 17:27
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
@greut greut requested a review from pyr January 3, 2018 12:24
@pyr pyr merged commit 30f0c00 into dev Jan 3, 2018
@pyr pyr deleted the godep branch January 3, 2018 21:13
greut added a commit that referenced this pull request Jan 4, 2018
* install using godep for management

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

* Update dockerfile

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
greut added a commit that referenced this pull request Jan 4, 2018
* install using godep for management

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

* Update dockerfile

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
greut added a commit that referenced this pull request Jan 11, 2018
* install using godep for management

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

* Update dockerfile

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants