Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle user-data compression with IO::Uncompress #4

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

mguegan
Copy link
Contributor

@mguegan mguegan commented Apr 15, 2019

After some testing today, cloud_init() doesn't work anymore. It seems that retrieved user-data is now compressed.

This lazy fix should take care of that.

Note :
A better way to handle this case may be done directly on get_data() :

  • add a check for compressed blob (on headers)
  • handle the compressed data

@pyr
Copy link
Contributor

pyr commented Apr 15, 2019

Hey! thanks for this, since gunzip silently returns the string when data is uncompressed, this can safely go in. There's still the case of multipart user-data, but there's only so much you can do with just the tooling available in base :-)

@pyr pyr merged commit d4e1b74 into exoscale:master Apr 15, 2019
@mguegan mguegan deleted the fix-compressed-user-data branch April 16, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants