New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Explicitly add javax dependencies for java11 #50

Merged

wdullaer merged 1 commit into master from java11-compat

Sep 2, 2020

Contributor

wdullaer commented Sep 2, 2020

Java11 removed javax APIs. The riemann TLS driver relies on these to
load certificates.
An explicit dependency needs to be added that provides/backports these
APIs. See https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist

I have tested this on java8 as well, and this does not seem to cause any
issues there.


          fix(deps): Explicitly add javax dependencies for java11

e3cf7b2

Java11 removed javax APIs. The riemann TLS driver relies on these to
load certificates.
An explicit dependency needs to be added that provides/backports these
APIs. See https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist

I have tested this on java8 as well, and this does not seem to cause any
issues there.

mpenet approved these changes

View reviewed changes

jespada approved these changes

View reviewed changes

wdullaer merged commit 62d37e1 into master

wdullaer deleted the java11-compat branch

September 2, 2020 08:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment