Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When edit an assignment, changing the number of review rounds doesn't work #972

Closed
ferryxo opened this issue Jun 14, 2017 · 3 comments
Closed

Comments

@ferryxo
Copy link
Contributor

ferryxo commented Jun 14, 2017

Using the code on Github (June 14, 2017), the button to update the number of review rounds doesn't work. It throws Uncaught TypeError: due_dates_table_element_list[i].id.split(...).last is not a function

@ferryxo ferryxo added the bug label Jun 14, 2017
rajanalwan added a commit to rajanalwan/expertiza that referenced this issue Oct 22, 2017
rajanalwan added a commit to rajanalwan/expertiza that referenced this issue Oct 23, 2017
rajanalwan added a commit to rajanalwan/expertiza that referenced this issue Oct 28, 2017
@ferryxo ferryxo added this to the Priority 2 milestone May 18, 2018
@efg
Copy link
Member

efg commented May 29, 2018

This problem is not fixed. You can change the # of rounds from 1 to 2. You can then change the # of rounds back to 1, and the assignment will appear to be saved with one round of review. But if you edit it again, the 2 rounds will still be present.

@ferryxo
Copy link
Contributor Author

ferryxo commented May 29, 2018

also, the 2 popups (confirm before changing and after changing the rounds) are not necessary. 1 is good.

@efg
Copy link
Member

efg commented Aug 6, 2019

This has been fixed.

@efg efg closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants