E1778 OSS project Purple: UI fixes for assignment creation #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Winbobob
reviewed
Nov 7, 2017
| @@ -118,6 +123,7 @@ def update | |||
| unless params.key?(:assignment_form) | |||
| @assignment = Assignment.find(params[:id]) | |||
| @assignment.course_id = params[:course_id] | |||
| puts "Perry1" | |||
There was a problem hiding this comment.
use "logger.debug" instead. and print messages that make sense e.g., @assignment.course_id instead of senseless strings.
ferryxo
changed the title
Winbobob
force-pushed
the
master
branch
3 times, most recently
from
2cc51d9
to
a1b78e0
Compare
Winbobob
force-pushed
the
master
branch
9 times, most recently
from
965f660
to
d08c1cb
Compare
Winbobob
force-pushed
the
master
branch
2 times, most recently
from
e813e60
to
3eafd4b
Compare
ferryxo
reviewed
Jan 24, 2018
| # Deleting Due date info from table if meta-review is unchecked. - UNITY ID: ralwan and vsreeni | ||
|
|
||
| @due_date_info = DueDate.find_each(parent_id: params[:id]) | ||
| puts @due_date_info.inspect |
| flash[:note] = 'The assignment was successfully saved....' | ||
|
|
||
| if params[:set_pressed][:bool] == 'false' | ||
| flash[:error] = "Submissions count greater than rounds of reviews. Please set the value before saving." |
There was a problem hiding this comment.
I think the error msg would be more useful if it's:
The available submissions for this assignment indicate that there are X rounds of review. Are you sure that you want to change it to Y rounds of review?
you have to calculate X first
app/models/assignment_form.rb
Outdated
| @@ -186,7 +186,7 @@ def set_up_assignment_review | |||
|
|
|||
| submissions = @assignment.find_due_dates('submission') | |||
| reviews = @assignment.find_due_dates('review') | |||
| @assignment.rounds_of_reviews = [@assignment.rounds_of_reviews, submissions.count, reviews.count].max | |||
| # @assignment.rounds_of_reviews = [@assignment.rounds_of_reviews, submissions.count, reviews.count].max | |||
There was a problem hiding this comment.
either delete this, or add comment why you deactivate this LoC.
| var original_round_count = <%= @assignment_form.assignment.rounds_of_reviews%>; | ||
|
|
||
| if(new_round_count < submissions_count){ | ||
| if(!confirm("Submissions count greater than rounds of reviews. Are you sure you want to change rounds of reviews?")){ |
There was a problem hiding this comment.
Not a big fan of confirm, alert and all blocking popup window. it's fine for now. but try to avoid them in the future.
|
New pull request for this project can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues #961 and #972.
By:
Vidhyalakshimi Sreenivasan - vsreeni
Rajan Alwan - ralwan