E1745. [TLD] Refactor response_controller.rb

[dipanshagupta]

Tasks completed:

1. Refactored response_controller.rb (Made changes in 4 existing methods, and created 1 method)
2. Added test cases in response_controller_spec.rb (Wrote 23 test cases)

[coveralls]

Coverage increased (+0.8%) to 51.659% when pulling 78a8b37 on dipanshagupta:master into a26cf3a on expertiza:master.

[coveralls]

Coverage increased (+0.8%) to 51.692% when pulling 78a8b37 on dipanshagupta:master into a26cf3a on expertiza:master.

[coveralls]

Coverage increased (+0.8%) to 51.67% when pulling ed0dc13 on dipanshagupta:master into a26cf3a on expertiza:master.

[coveralls]

Coverage increased (+0.8%) to 51.681% when pulling 1e4e5b3 on dipanshagupta:master into a26cf3a on expertiza:master.

[coveralls]

Coverage increased (+0.7%) to 51.592% when pulling 6e05d26 on dipanshagupta:master into a26cf3a on expertiza:master.

[Winbobob]

Good refactoring!

[Winbobob]

Hi team,

• I think your refactoring is very good!
• For your tests, you put all stubs in before(:each) block. I don't think it is a good idea.
  • In your case, every test will execute many unnecessary stubs, which may take more time to run tests.
  • It will be better if you put necessary stubs in each test and only put frequently-used code in before(:each) block.

Thanks,
Zhewei

[coveralls]

Coverage increased (+0.2%) to 51.055% when pulling 6892b6d on dipanshagupta:master into a26cf3a on expertiza:master.

[Winbobob]

I don't think the logic here is correct. participant_type is an array of participants, instead of the type of participant. I think this mistake is due to your misleading variable names. And you just refactor code without varifying the correctness.