E1786. Bookmark Code Fix #1039
Closed
E1786. Bookmark Code Fix #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Winbobob
force-pushed
the
master
branch
3 times, most recently
from
2cc51d9
to
a1b78e0
Compare
Winbobob
reviewed
Nov 15, 2017
| @@ -70,9 +70,7 @@ | |||
|
|
|||
| <br /> | |||
|
|
|||
| <%= link_to 'New bookmark', :action => 'new', :id => @topic.id %> | | |||
| <%= link_to 'Back', :controller=> 'sign_up_sheet', :action=>'list', :assignment_id => @topic.assignment_id %> | |||
There was a problem hiding this comment.
Could you explain why you remove the back link?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
->In this code fix, we have resolved the issue of back button not functioning properly when a student navigates through the bookmarks and clicks on the back button.
->Code fix is also about adding questionnaire and fixing the rubric system that has trouble with bookmark selection and creation of new questionnaires.