E1817: Adding Student Generated Questions to Rubric #1178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Winbobob
reviewed
May 8, 2018
| click_link "TestAssignment" | ||
| click_link "Your work" | ||
| end | ||
| #def signup_topic |
There was a problem hiding this comment.
You can delete the code instead of comment out them.
Winbobob
reviewed
May 8, 2018
| @participant = AssignmentParticipant.find(params[:id]) | ||
| @team = Team.find(@participant.team.id) | ||
| if @team.srq_id.nil? then | ||
| @questionnaire = Questionnaire.new |
There was a problem hiding this comment.
Questionnaire creation code can use create instead. And it is unnecessary to use the instance variable. Also, you can make values as parameters, instead of assigning them one by one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please put the title of your pull request in the following format: Project ID. Name
for example,
[Project id/Independent study/Issue fix/...]. project name, eg.,E904. Integrating courses and assignments on Expertiza with MoodleWe suggest you include below information in your pull request: